[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/7] test-keyval: Demonstrate misparse of ', ' with implied ke
From: |
Markus Armbruster |
Subject: |
[PATCH v4 2/7] test-keyval: Demonstrate misparse of ', ' with implied key |
Date: |
Sun, 11 Oct 2020 09:35:00 +0200 |
Add a test for "val,,ue" with implied key. Documentation says this
should parse as implied key with value "val", then fail. The code
parses it as implied key with value "val,ue", then succeeds. The next
commit will fix it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/test-keyval.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/test-keyval.c b/tests/test-keyval.c
index e331a84149..f02bdf7029 100644
--- a/tests/test-keyval.c
+++ b/tests/test-keyval.c
@@ -182,6 +182,13 @@ static void test_keyval_parse(void)
error_free_or_abort(&err);
g_assert(!qdict);
+ /* Implied key's value can't have comma (qemu_opts_parse(): it can) */
+ /* BUG: it can */
+ qdict = keyval_parse("val,,ue", "implied", &error_abort);
+ g_assert_cmpuint(qdict_size(qdict), ==, 1);
+ g_assert_cmpstr(qdict_get_try_str(qdict, "implied"), ==, "val,ue");
+ qobject_unref(qdict);
+
/* Empty key is not an implied key */
qdict = keyval_parse("=val", "implied", &err);
error_free_or_abort(&err);
--
2.26.2
- [PATCH v4 0/7] qemu-storage-daemon: Remove QemuOpts from --object, Markus Armbruster, 2020/10/11
- [PATCH v4 3/7] keyval: Fix parsing of ',' in value of implied key, Markus Armbruster, 2020/10/11
- [PATCH v4 1/7] keyval: Fix and clarify grammar, Markus Armbruster, 2020/10/11
- [PATCH v4 2/7] test-keyval: Demonstrate misparse of ', ' with implied key,
Markus Armbruster <=
- [PATCH v4 6/7] qom: Add user_creatable_print_help_from_qdict(), Markus Armbruster, 2020/10/11
- [PATCH v4 7/7] qemu-storage-daemon: Remove QemuOpts from --object parser, Markus Armbruster, 2020/10/11
- [PATCH v4 5/7] qom: Factor out helpers from user_creatable_print_help(), Markus Armbruster, 2020/10/11
- [PATCH v4 4/7] keyval: Parse help options, Markus Armbruster, 2020/10/11
- Re: [PATCH v4 0/7] qemu-storage-daemon: Remove QemuOpts from --object, Kevin Wolf, 2020/10/12