[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert |
|
Date: |
Mon, 19 Oct 2020 13:45:25 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Sun 18 Oct 2020 08:34:39 AM CEST, Zhengui li wrote:
> @@ -2729,6 +2757,10 @@ out:
> qemu_opts_del(opts);
> qemu_opts_free(create_opts);
> qemu_opts_del(sn_opts);
> + if (s.target && rate_limit &&
> + blk_get_public(s.target)->throttle_group_member.throttle_state) {
> + blk_io_limits_disable(s.target);
> + }
> qobject_unref(open_opts);
> blk_unref(s.target);
> if (s.src) {
Apart from the comments that I wrote to the other patch, which also
apply to this one, blk_delete() already calls blk_io_limits_disable() so
I don't think you need to do it manually here.
Berto