[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable warning |
Date: |
Tue, 20 Oct 2020 10:16:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 20/10/2020 à 09:36, Chenqun (kuhn) a écrit :
> Ping!
>
> Hello,
>
> Maybe this patch, some people have any other suggestions? Or, maybe
> missed to queue?
Hi,
As we've seen by reviewing previous versions, this change is not really
trivial, so I will not take it via the trivial queue.
Perhaps via block I/O queue (Stefan?), Dirty Bitmaps (John?) or
Migration (Juan?).
Thanks,
Laurent
> Thanks,
> Chen Qun
>
>> -----Original Message-----
>> From: Vladimir Sementsov-Ogievskiy [mailto:vsementsov@virtuozzo.com]
>> Sent: Wednesday, October 14, 2020 11:56 PM
>> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu-devel@nongnu.org;
>> qemu-trivial@nongnu.org
>> Cc: mreitz@redhat.com; stefanha@redhat.com; fam@euphon.net;
>> eblake@redhat.com; jsnow@redhat.com; quintela@redhat.com;
>> dgilbert@redhat.com; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
>> ganqixin <ganqixin@huawei.com>; qemu-block@nongnu.org; Euler Robot
>> <euler.robot@huawei.com>; Laurent Vivier <laurent@vivier.eu>; Li Qiang
>> <liq3ea@gmail.com>
>> Subject: Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized
>> variable
>> warning
>>
>> 14.10.2020 14:44, Chen Qun wrote:
>>> A default value is provided for the variable 'bitmap_name' to avoid compiler
>> warning.
>>>
>>> The compiler show warning:
>>> migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’
>>> may be used uninitialized in this function [-Wmaybe-uninitialized]
>>> g_strlcpy(s->bitmap_name, bitmap_name,
>> sizeof(s->bitmap_name));
>>>
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Reported-by: Euler Robot<euler.robot@huawei.com>
>>> Signed-off-by: Chen Qun<kuhn.chenqun@huawei.com>
>>
>> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>> --
>> Best regards,
>> Vladimir