[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 05/14] block: drop extra error propagation for bdrv_set_backin
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v4 05/14] block: drop extra error propagation for bdrv_set_backing_hd |
Date: |
Tue, 20 Oct 2020 16:03:02 +0300 |
bdrv_set_backing_hd now returns status, let's use it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
block.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 46d4ad0ea6..0ee36c1869 100644
--- a/block.c
+++ b/block.c
@@ -3018,11 +3018,9 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict
*parent_options,
/* Hook up the backing file link; drop our reference, bs owns the
* backing_hd reference now */
- bdrv_set_backing_hd(bs, backing_hd, &local_err);
+ ret = bdrv_set_backing_hd(bs, backing_hd, errp);
bdrv_unref(backing_hd);
- if (local_err) {
- error_propagate(errp, local_err);
- ret = -EINVAL;
+ if (ret < 0) {
goto free_exit;
}
--
2.21.3
- [PATCH v4 00/14] block: deal with errp: part I, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 02/14] block: use return status of bdrv_append(), Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 01/14] block: return status from bdrv_append and friends, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 04/14] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 05/14] block: drop extra error propagation for bdrv_set_backing_hd,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v4 06/14] block/mirror: drop extra error propagation in commit_active_start(), Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 09/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 07/14] blockjob: return status from block_job_set_speed(), Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 11/14] block/qcow2: read_cache_sizes: return status value, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 12/14] block/qcow2: simplify qcow2_co_invalidate_cache(), Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths, Vladimir Sementsov-Ogievskiy, 2020/10/20
- [PATCH v4 13/14] block/qed: bdrv_qed_do_open: deal with errp, Vladimir Sementsov-Ogievskiy, 2020/10/20