[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 14/28] util/vhost-user-server: check EOF when reading payload
From: |
Stefan Hajnoczi |
Subject: |
[PULL v2 14/28] util/vhost-user-server: check EOF when reading payload |
Date: |
Thu, 22 Oct 2020 12:27:12 +0100 |
Unexpected EOF is an error that must be reported.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200924151549.913737-9-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
util/vhost-user-server.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c
index a7b7a9897f..981908fef0 100644
--- a/util/vhost-user-server.c
+++ b/util/vhost-user-server.c
@@ -169,8 +169,10 @@ vu_message_read(VuDev *vu_dev, int conn_fd, VhostUserMsg
*vmsg)
};
if (vmsg->size) {
rc = qio_channel_readv_all_eof(ioc, &iov_payload, 1, &local_err);
- if (rc == -1) {
- error_report_err(local_err);
+ if (rc != 1) {
+ if (local_err) {
+ error_report_err(local_err);
+ }
goto fail;
}
}
--
2.26.2
- [PULL v2 04/28] util/vhost-user-server: generic vhost user server, (continued)
- [PULL v2 04/28] util/vhost-user-server: generic vhost user server, Stefan Hajnoczi, 2020/10/22
- [PULL v2 05/28] block: move logical block size check function to a common utility function, Stefan Hajnoczi, 2020/10/22
- [PULL v2 06/28] block/export: vhost-user block device backend server, Stefan Hajnoczi, 2020/10/22
- [PULL v2 07/28] MAINTAINERS: Add vhost-user block device backend server maintainer, Stefan Hajnoczi, 2020/10/22
- [PULL v2 08/28] util/vhost-user-server: s/fileds/fields/ typo fix, Stefan Hajnoczi, 2020/10/22
- [PULL v2 09/28] util/vhost-user-server: drop unnecessary QOM cast, Stefan Hajnoczi, 2020/10/22
- [PULL v2 10/28] util/vhost-user-server: drop unnecessary watch deletion, Stefan Hajnoczi, 2020/10/22
- [PULL v2 11/28] block/export: consolidate request structs into VuBlockReq, Stefan Hajnoczi, 2020/10/22
- [PULL v2 12/28] util/vhost-user-server: drop unused DevicePanicNotifier, Stefan Hajnoczi, 2020/10/22
- [PULL v2 13/28] util/vhost-user-server: fix memory leak in vu_message_read(), Stefan Hajnoczi, 2020/10/22
- [PULL v2 14/28] util/vhost-user-server: check EOF when reading payload,
Stefan Hajnoczi <=
- [PULL v2 16/28] block/export: report flush errors, Stefan Hajnoczi, 2020/10/22
- [PULL v2 15/28] util/vhost-user-server: rework vu_client_trip() coroutine lifecycle, Stefan Hajnoczi, 2020/10/22
- [PULL v2 17/28] block/export: convert vhost-user-blk server to block export API, Stefan Hajnoczi, 2020/10/22
- [PULL v2 18/28] util/vhost-user-server: move header to include/, Stefan Hajnoczi, 2020/10/22
- [PULL v2 19/28] util/vhost-user-server: use static library in meson.build, Stefan Hajnoczi, 2020/10/22
- [PULL v2 20/28] qemu-storage-daemon: avoid compiling blockdev_ss twice, Stefan Hajnoczi, 2020/10/22
- [PULL v2 21/28] block: move block exports to libblockdev, Stefan Hajnoczi, 2020/10/22
- [PULL v2 23/28] block/export: add vhost-user-blk multi-queue support, Stefan Hajnoczi, 2020/10/22
- [PULL v2 24/28] block/io: fix bdrv_co_block_status_above, Stefan Hajnoczi, 2020/10/22
- [PULL v2 22/28] block/export: add iothread and fixed-iothread options, Stefan Hajnoczi, 2020/10/22