Re: [PULL v2 00/28] Block patches

[Peter Maydell]

On Thu, 22 Oct 2020 at 12:27, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit ac793156f650ae2d77834932d72224175ee69086:
>
>   Merge remote-tracking branch 
> 'remotes/pmaydell/tags/pull-target-arm-20201020-1' into staging (2020-10-20 
> 21:11:35 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 32a3fd65e7e3551337fd26bfc0e2f899d70c028c:
>
>   iotests: add commit top->base cases to 274 (2020-10-22 09:55:39 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> v2:
>  * Fix format string issues on 32-bit hosts [Peter]
>  * Fix qemu-nbd.c CONFIG_POSIX ifdef issue [Eric]
>  * Fix missing eventfd.h header on macOS [Peter]
>  * Drop unreliable vhost-user-blk test (will send a new patch when ready) 
> [Peter]
>
> This pull request contains the vhost-user-blk server by Coiby Xu along with my
> additions, block/nvme.c alignment and hardware error statistics by Philippe
> Mathieu-Daudé, and bdrv_co_block_status_above() fixes by Vladimir
> Sementsov-Ogievskiy.

Fails to link on FreeBSD, NetBSD, OpenBSD, OSX:

ld: error: undefined symbol: blk_exp_vhost_user_blk
>>> referenced by export.c:58 (../src/block/export/export.c:58)
>>>               block_export_export.c.o:(blk_exp_add) in archive 
>>> libblockdev.fa
c++: error: linker command failed with exit code 1 (use -v to see invocation)

thanks
-- PMM