[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 14/19] util/vfio-helpers: Pass minimum page size to qemu_v
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 14/19] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci() |
Date: |
Tue, 27 Oct 2020 09:50:04 +0000 |
On Mon, Oct 26, 2020 at 11:54:59AM +0100, Philippe Mathieu-Daudé wrote:
> @@ -737,6 +738,17 @@ static int nvme_init(BlockDriverState *bs, const char
> *device, int namespace,
> }
>
> device_page_size_min = 1u << (12 + NVME_CAP_MPSMIN(cap));
> + device_page_size_max = 1u << (12 + NVME_CAP_MPSMAX(cap));
> + if (iommu_page_size_min > device_page_size_max) {
> + g_autofree char *iommu_page_size_s =
> size_to_str(iommu_page_size_min);
> + g_autofree char *device_page_size_s =
> size_to_str(device_page_size_max);
> +
> + error_setg(errp, "IOMMU minimum page size (%s)"
> + " too big for device (max %s)",
> + iommu_page_size_s, device_page_size_s);
> + ret = -EINVAL;
> + goto out;
> + }
I thought you and Eric worked on a solution to support smaller device
pages on bigger IOMMU pages? For example, 4KB device page size on 64KB
IOMMU page size.
Won't this check be removed again very soon? Why add it at all?
signature.asc
Description: PGP signature
- Re: [PATCH v2 07/19] util/vfio-helpers: Trace PCI BAR region info, (continued)
- [PATCH v2 08/19] util/vfio-helpers: Trace where BARs are mapped, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 09/19] util/vfio-helpers: Improve DMA trace events, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 10/19] util/vfio-helpers: Convert vfio_dump_mapping to trace events, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 11/19] util/vfio-helpers: Let qemu_vfio_dma_map() propagate Error, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 12/19] util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 13/19] util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report(), Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 14/19] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci(), Philippe Mathieu-Daudé, 2020/10/26
- Re: [PATCH v2 14/19] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci(),
Stefan Hajnoczi <=
- [PATCH v2 15/19] util/vfio-helpers: Report error when IOMMU page size is not supported, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 16/19] util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs(), Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 17/19] util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq(), Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 18/19] block/nvme: Switch to using the MSIX API, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 19/19] util/vfio-helpers: Remove now unused qemu_vfio_pci_init_irq(), Philippe Mathieu-Daudé, 2020/10/26