[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error |
Date: |
Tue, 27 Oct 2020 14:55:33 +0100 |
Just for consistency, following the example documented since
commit e3fe3988d7 ("error: Document Error API usage rules"),
return a boolean value indicating an error is set or not.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
block/nvme.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/nvme.c b/block/nvme.c
index 8b0fd59c6ea..74994c442e5 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -506,9 +506,11 @@ static int nvme_cmd_sync(BlockDriverState *bs,
NVMeQueuePair *q,
return ret;
}
-static void nvme_identify(BlockDriverState *bs, int namespace, Error **errp)
+/* Returns true on success, false on failure. */
+static bool nvme_identify(BlockDriverState *bs, int namespace, Error **errp)
{
BDRVNVMeState *s = bs->opaque;
+ bool ret = false;
union {
NvmeIdCtrl ctrl;
NvmeIdNs ns;
@@ -585,10 +587,13 @@ static void nvme_identify(BlockDriverState *bs, int
namespace, Error **errp)
goto out;
}
+ ret = true;
s->blkshift = lbaf->ds;
out:
qemu_vfio_dma_unmap(s->vfio, id);
qemu_vfree(id);
+
+ return ret;
}
static bool nvme_poll_queue(NVMeQueuePair *q)
--
2.26.2
- [PATCH 08/25] block/nvme: Simplify device reset, (continued)
[PATCH 10/25] block/nvme: Use unsigned integer for queue counter/size, Philippe Mathieu-Daudé, 2020/10/27
[PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error,
Philippe Mathieu-Daudé <=
[PATCH 13/25] block/nvme: Introduce Completion Queue definitions, Philippe Mathieu-Daudé, 2020/10/27