[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/25] block/nvme: Simplify ADMIN queue access
From: |
Auger Eric |
Subject: |
Re: [PATCH 16/25] block/nvme: Simplify ADMIN queue access |
Date: |
Wed, 28 Oct 2020 15:25:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote:
> We don't need to dereference from BDRVNVMeState each time.
> Use a NVMeQueuePair pointer to the admin queue and use it.
double "use"
> The nvme_init() becomes easier to review, matching the style
> of nvme_add_io_queue().>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> block/nvme.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index d5df30ec074..2d3648694b0 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -699,6 +699,7 @@ static int nvme_init(BlockDriverState *bs, const char
> *device, int namespace,
> Error **errp)
> {
> BDRVNVMeState *s = bs->opaque;
> + NVMeQueuePair *q;
> AioContext *aio_context = bdrv_get_aio_context(bs);
> int ret;
> uint64_t cap;
> @@ -781,19 +782,18 @@ static int nvme_init(BlockDriverState *bs, const char
> *device, int namespace,
>
> /* Set up admin queue. */
> s->queues = g_new(NVMeQueuePair *, 1);
> - s->queues[INDEX_ADMIN] = nvme_create_queue_pair(s, aio_context, 0,
> - NVME_QUEUE_SIZE,
> - errp);
> - if (!s->queues[INDEX_ADMIN]) {
> + q = nvme_create_queue_pair(s, aio_context, 0, NVME_QUEUE_SIZE, errp);
> + if (!q) {
> ret = -EINVAL;
> goto out;
> }
> + s->queues[INDEX_ADMIN] = q;
> s->queue_count = 1;
> QEMU_BUILD_BUG_ON((NVME_QUEUE_SIZE - 1) & 0xF000);
> regs->aqa = cpu_to_le32(((NVME_QUEUE_SIZE - 1) << AQA_ACQS_SHIFT) |
> ((NVME_QUEUE_SIZE - 1) << AQA_ASQS_SHIFT));
> - regs->asq = cpu_to_le64(s->queues[INDEX_ADMIN]->sq.iova);
> - regs->acq = cpu_to_le64(s->queues[INDEX_ADMIN]->cq.iova);
> + regs->asq = cpu_to_le64(q->sq.iova);
> + regs->acq = cpu_to_le64(q->cq.iova);
>
> /* After setting up all control registers we can enable device now. */
> regs->cc = cpu_to_le32((ctz32(NVME_CQ_ENTRY_BYTES) << CC_IOCQES_SHIFT) |
>
- Re: [PATCH 13/25] block/nvme: Introduce Completion Queue definitions, (continued)
[PATCH 14/25] block/nvme: Use definitions instead of magic values in add_io_queue(), Philippe Mathieu-Daudé, 2020/10/27
[PATCH 16/25] block/nvme: Simplify ADMIN queue access, Philippe Mathieu-Daudé, 2020/10/27
[PATCH 15/25] block/nvme: Correctly initialize Admin Queue Attributes, Philippe Mathieu-Daudé, 2020/10/27
[PATCH 18/25] block/nvme: Pass AioContext argument to nvme_add_io_queue(), Philippe Mathieu-Daudé, 2020/10/27
[PATCH 17/25] block/nvme: Simplify nvme_cmd_sync(), Philippe Mathieu-Daudé, 2020/10/27