Re: [PATCH v3 15/15] python/qemu: add qemu package itself to pipenv

[John Snow]

On 10/28/20 6:59 PM, Cleber Rosa wrote:
> On Tue, Oct 20, 2020 at 03:35:55PM -0400, John Snow wrote:
> > This adds the python qemu packages themselves to the pipenv manifest.
> > 'pipenv sync' will create a virtual environment sufficient to use the SDK.
> > 'pipenv sync --dev' will create a virtual environment sufficient to use
> > and test the SDK (with pylint, mypy, isort, flake8, etc.)
> >
> > The qemu packages are installed in 'editable' mode; all changes made to
> > the python package inside the git tree will be reflected in the
> > installed package without reinstallation. This includes changes made
> > via git pull and so on.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> Tested-by: Cleber Rosa <crosa@redhat.com>

Thanks! It looks like the major questions remaining are:

- Seriously, how should we lay the files out, and what should the 
package names be?
- Do we want to use something besides pipenv?

And from the CI series, a whole heap of other questions ;)

Thanks for taking a look and testing. It took a non-trivial amount of 
time to get all of this corralled together in precisely the right way to 
make it work in a variety of environments, so I am hoping it's "close" 
to something that's going to work for everyone.

--js