[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-5.2 v2 03/25] block/nvme: Report warning with warn_report()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-5.2 v2 03/25] block/nvme: Report warning with warn_report() |
Date: |
Thu, 29 Oct 2020 10:32:44 +0100 |
Instead of displaying warning on stderr, use warn_report()
which also displays it on the monitor.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 739a0a700cb..6f1d7f9b2a1 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -399,8 +399,8 @@ static bool nvme_process_completion(NVMeQueuePair *q)
}
cid = le16_to_cpu(c->cid);
if (cid == 0 || cid > NVME_QUEUE_SIZE) {
- fprintf(stderr, "Unexpected CID in completion queue: %" PRIu32
"\n",
- cid);
+ warn_report("NVMe: Unexpected CID in completion queue: %"PRIu32", "
+ "queue size: %u", cid, NVME_QUEUE_SIZE);
continue;
}
trace_nvme_complete_command(s, q->index, cid);
--
2.26.2
- [PATCH-for-5.2 v2 00/25] block/nvme: Fix Aarch64 or big-endian hosts, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 01/25] MAINTAINERS: Cover 'block/nvme.h' file, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 02/25] block/nvme: Use hex format to display offset in trace events, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 03/25] block/nvme: Report warning with warn_report(),
Philippe Mathieu-Daudé <=
- [PATCH-for-5.2 v2 04/25] block/nvme: Trace controller capabilities, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 05/25] block/nvme: Trace nvme_poll_queue() per queue, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 08/25] block/nvme: Move definitions before structure declarations, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 07/25] block/nvme: Trace queue pair creation/deletion, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 09/25] block/nvme: Use unsigned integer for queue counter/size, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 10/25] block/nvme: Make nvme_identify() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 11/25] block/nvme: Make nvme_init_queue() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/29
- [PATCH-for-5.2 v2 12/25] block/nvme: Introduce Completion Queue definitions, Philippe Mathieu-Daudé, 2020/10/29