Re: [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests

[Stefan Hajnoczi]

On Mon, Nov 02, 2020 at 05:43:19AM -0500, Michael S. Tsirkin wrote:
> On Fri, Oct 30, 2020 at 08:42:22AM -0400, Michael S. Tsirkin wrote:
> > On Tue, Oct 27, 2020 at 05:35:16PM +0000, Stefan Hajnoczi wrote:
> > > This patch series solves some issues with the new vhost-user-blk-server 
> > > and
> > > adds the qtest test case. The test case was not included in the pull 
> > > request
> > > that introduced the vhost-user-blk server because of reliability issues 
> > > that
> > > are fixed in this patch series.
> > 
> > 
> > Fails make check for me:
> > 
> > Running test qtest-i386/qos-test
> > Broken pipe
> > ../qemu/tests/qtest/libqtest.c:161: kill_qemu() detected QEMU death from 
> > signal 11 (Segmentation fault) (core dumped)
> > ERROR qtest-i386/qos-test - too few tests run (expected 92, got 65)
> > make: *** [Makefile.mtest:1857: run-test-230] Error 1
> 
> And here's the coredump:

Thanks! qemu.git/master is broken. The segfault was introduced in
adb29c027341ba095a3ef4beef6aaef86d3a520e ("vhost-blk: set features
before setting inflight feature"). The code in question has no test
coverage so we didn't know that vhost-user-blk is broken in QEMU.

I have sent a patch to revert the commit. Let's do that for QEMU 5.2
unless a straightforward fix can be provided in place of the revert.

Stefan

signature.asc
Description: PGP signature