Re: [PATCH-for-6.0 1/3] hw/virtio: Add configure switch to disable legacy VIRTIO

[Paolo Bonzini]

On 05/11/20 13:43, Philippe Mathieu-Daudé wrote:
> +virtio_legacy="enabled"
>   virtiofsd="auto"
>   virtfs=""
>   libudev="auto"
> @@ -1001,6 +1002,10 @@ for opt do
>     ;;
>     --enable-libudev) libudev="enabled"
>     ;;
> +  --disable-virtio-legacy) virtio_legacy="disabled"
> +  ;;
> +  --enable-virtio-legacy) virtio_legacy="enabled"
> +  ;;
>     --disable-virtiofsd) virtiofsd="disabled"
>     ;;
>     --enable-virtiofsd) virtiofsd="enabled"
> @@ -1764,6 +1769,7 @@ disabled with --disable-FEATURE, default is enabled if 
> available:
>     vnc-png         PNG compression for VNC server
>     cocoa           Cocoa UI (Mac OS X only)
>     virtfs          VirtFS
> +  virtio-legacy   enable support for legacy virtio (before VIRTIO 1.0)
>     virtiofsd       build virtiofs daemon (virtiofsd)
>     libudev         Use libudev to enumerate host devices
>     mpath           Multipath persistent reservation passthrough
> @@ -6816,6 +6822,10 @@ if test "$safe_stack" = "yes"; then
>     echo "CONFIG_SAFESTACK=y" >> $config_host_mak
>   fi
>   
> +if test "$virtio_legacy" = "enabled"; then
> +  echo "CONFIG_VIRTIO_LEGACY=y" >> $config_host_mak
> +fi

Please use meson_options.txt instead (you can make it a boolean option 
with true/false as the choices for the shell variable).

Paolo

>   # If we're using a separate build tree, set it up now.
>   # DIRS are directories which we simply mkdir in the build tree;
>   # LINKS are things to symlink back into the source tree
> diff --git a/meson.build b/meson.build
> index 39ac5cf6d8a..51406c28c6e 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2061,6 +2061,7 @@
>   summary_info += {'Block whitelist (rw)': 
> config_host['CONFIG_BDRV_RW_WHITELIST']}
>   summary_info += {'Block whitelist (ro)': 
> config_host['CONFIG_BDRV_RO_WHITELIST']}
>   summary_info += {'VirtFS support':    config_host.has_key('CONFIG_VIRTFS')}
> +summary_info += {'Legacy VIRTIO support': 
> config_host.has_key('CONFIG_VIRTIO_LEGACY')}