[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/7] block: add bdrv_replace_node_common()
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v2 2/7] block: add bdrv_replace_node_common() |
|
Date: |
Fri, 06 Nov 2020 16:27:41 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 06 Nov 2020 01:42:36 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Add new parameter to bdrv_replace_node(): auto_skip. With
> auto_skip=false we'll have stricter behavior: update _all_ from
> parents or fail. New behaviour will be used in the following commit in
> block.c, so keep original function name as public interface.
>
> Note: new error message is a bit funny in contrast with further
> "Cannot" in case of frozen child, but we'd better keep some difference
> to make it possible to distinguish one from another on failure. Still,
> actually we'd better refactor should_update_child() call to distinguish
> also different kinds of "should not". Let's do it later.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
- [PATCH v2 4/7] block: add bdrv_refresh_perms() helper, (continued)
- [PATCH v2 1/7] block: add forgotten bdrv_abort_perm_update() to bdrv_co_invalidate_cache(), Vladimir Sementsov-Ogievskiy, 2020/11/06
- [PATCH v2 5/7] block: bdrv_set_perm() drop redundant parameters., Vladimir Sementsov-Ogievskiy, 2020/11/06
- [PATCH v2 2/7] block: add bdrv_replace_node_common(), Vladimir Sementsov-Ogievskiy, 2020/11/06
- Re: [PATCH v2 2/7] block: add bdrv_replace_node_common(),
Alberto Garcia <=
- [PATCH v2 6/7] block: bdrv_child_set_perm() drop redundant parameters., Vladimir Sementsov-Ogievskiy, 2020/11/06
- [PATCH v2 7/7] block: drop tighten_restrictions, Vladimir Sementsov-Ogievskiy, 2020/11/06
- Re: [PATCH v2 0/7] block: permission update fix & refactor, Max Reitz, 2020/11/09