[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/3] hw/block/m25p80: Fix Numonyx NVCFG DIO and QIO bit po
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 1/3] hw/block/m25p80: Fix Numonyx NVCFG DIO and QIO bit polarity |
|
Date: |
Mon, 9 Nov 2020 15:21:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/6/20 2:32 AM, Joe Komlodi wrote:
> QIO and DIO modes should be enabled when the bits in NVCFG are set to 0.
> This matches the behavior of the other bits in the NVCFG register.
Is this material for the 5.2 release?
>
> Signed-off-by: Joe Komlodi <komlodi@xilinx.com>
> ---
> hw/block/m25p80.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 483925f..4255a6a 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -783,10 +783,10 @@ static void reset_memory(Flash *s)
> s->enh_volatile_cfg |= EVCFG_OUT_DRIVER_STRENGTH_DEF;
> s->enh_volatile_cfg |= EVCFG_VPP_ACCELERATOR;
> s->enh_volatile_cfg |= EVCFG_RESET_HOLD_ENABLED;
> - if (s->nonvolatile_cfg & NVCFG_DUAL_IO_MASK) {
> + if (!(s->nonvolatile_cfg & NVCFG_DUAL_IO_MASK)) {
> s->enh_volatile_cfg |= EVCFG_DUAL_IO_ENABLED;
> }
> - if (s->nonvolatile_cfg & NVCFG_QUAD_IO_MASK) {
> + if (!(s->nonvolatile_cfg & NVCFG_QUAD_IO_MASK)) {
> s->enh_volatile_cfg |= EVCFG_QUAD_IO_ENABLED;
> }
> if (!(s->nonvolatile_cfg & NVCFG_4BYTE_ADDR_MASK)) {
>