[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to destroy_file() |
Date: |
Thu, 12 Nov 2020 17:04:35 +0000 |
On Thu, Nov 12, 2020 at 03:32:58PM +0100, Max Reitz wrote:
> On 11.11.20 13:43, Stefan Hajnoczi wrote:
> > The function is used not just for image files but also for UNIX domain
> > sockets (QMP monitor and vhost-user-blk). Reflect that in the name.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > tests/qtest/vhost-user-blk-test.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
>
> [...]
>
> > @@ -731,7 +732,7 @@ static char *start_vhost_user_blk(GString *cmd_line,
> > int vus_instances,
> > sock_path = g_strdup(sock_path_tempate);
> > fd = mkstemp(sock_path);
> > g_assert_cmpint(fd, >=, 0);
> > - g_test_queue_destroy(drive_destroy, sock_path);
> > + g_test_queue_destroy(drive_file, sock_path);
>
> s/drive_file/destroy_file/, I think :)
Oops! The following commit removes this line so I didn't notice this
issue: "vhost-user-blk-test: fix races by using fd passing".
Michael: If you want this intermediate commit fixed for bisectability I
will respin. Otherwise the patches in your tree are fine.
signature.asc
Description: PGP signature
- [PATCH for-5.2 00/10] block/export: vhost-user-blk server tests and input validation, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 01/10] test: new qTest case to test the vhost-user-blk-server, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 02/10] tests/qtest: add multi-queue test case to vhost-user-blk-test, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 03/10] libqtest: add qtest_socket_server(), Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to destroy_file(), Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 06/10] vhost-user-blk-test: drop unused return value, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 07/10] vhost-user-blk-test: fix races by using fd passing, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 08/10] block/export: port virtio-blk discard/write zeroes input validation, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 09/10] vhost-user-blk-test: test discard/write zeroes invalid inputs, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 10/10] block/export: port virtio-blk read/write range check, Stefan Hajnoczi, 2020/11/11