Re: [PATCH] curl: remove compatibility code

[Daniel P . Berrangé]

On Tue, Nov 17, 2020 at 01:40:56PM +0100, Paolo Bonzini wrote:
> On 17/11/20 12:46, Daniel P. Berrangé wrote:
> > On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote:
> > > cURL 7.16.0 was released in October 2006.  Just remove code that is
> > > in all likelihood not being used anywhere.
> > 
> > Rather than assuming that, we should be picking our minimum version
> > and enforcing that in configure/meson.
> > 
> > Currently, we have a manual code compile check for curl_multi_setopt,
> > after doing a pkg-config check with no min version.
> > 
> > We should set a min version in pkg-config and drop the compile check
> > in configure.
> > 
> > Based on repology.org and our platform support matrix, RHEL-7 looks
> > like the oldest curl that we need to care about, 7.29.0
> 
> That is complicated a bit by the fact that curl is detected with both
> pkg-config and curl-config.  That is probably unnecessary too, since we do
> not need any of the options that are exclusive to curl-config, such as --ca.
> If we can drop curl-config, moving the detection to meson is much easier.

That's just another bit of historical cruft - use of curl-config dates
back to when you introduced pkg-config for curl in 2010, to cope with
distros that didn't ship pkg-config files yet. Our supported platforms
today will all have pkg-config for curl, so we can drop curl-config too.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|