[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] block: qcow2: remove the created file on initializati
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v3 2/2] block: qcow2: remove the created file on initialization error |
|
Date: |
Tue, 08 Dec 2020 16:26:18 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 08 Dec 2020 03:21:59 PM CET, Maxim Levitsky wrote:
> If the qcow initialization fails, we should remove the file if it was
> already created, to avoid leaving stale files around.
>
> We already do this for luks raw images.
>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
> ret = qcow2_co_create(create_options, errp);
> if (ret < 0) {
> +
> + Error *local_delete_err = NULL;
Why that empty line though?
Berto