[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 0/3] qcow2: don't leave partially initialized file on imag
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v6 0/3] qcow2: don't leave partially initialized file on image creation |
Date: |
Thu, 07 Jan 2021 12:22:20 +0200 |
User-agent: |
Evolution 3.36.5 (3.36.5-1.fc32) |
On Thu, 2020-12-17 at 19:09 +0200, Maxim Levitsky wrote:
> Use the bdrv_co_delete_file interface to delete the underlying
> file if qcow2 initialization fails (e.g due to bad encryption secret)
>
> This makes the qcow2 driver behave the same way as the luks driver behaves.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1845353
>
> V3: addressed review feedback and reworked commit messages
>
> V4: got rid of code duplication by adding bdrv_co_delete_file_noerr
> and made the qcow2 driver use this function to delete
> both the main and the data file.
>
> V5: addresssed review feedback on reworked version.
>
> V6: addressed most of the review feedback.
>
> Best regards,
> Maxim Levitsky
>
> Maxim Levitsky (3):
> crypto: luks: Fix tiny memory leak
> block: add bdrv_co_delete_file_noerr
> block: qcow2: remove the created file on initialization error
>
> block.c | 22 ++++++++++++++++++++++
> block/crypto.c | 13 ++-----------
> block/qcow2.c | 8 +++++---
> include/block/block.h | 1 +
> 4 files changed, 30 insertions(+), 14 deletions(-)
>
> --
> 2.26.2
>
>
>
Any update on this?
Best regards,
Maxim Levitsky
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v6 0/3] qcow2: don't leave partially initialized file on image creation,
Maxim Levitsky <=