[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/11] iotests: add testenv.py
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v6 08/11] iotests: add testenv.py |
Date: |
Fri, 15 Jan 2021 14:20:19 +0100 |
Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 15.01.2021 15:45, Kevin Wolf wrote:
> > Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 15.01.2021 14:18, Kevin Wolf wrote:
> > > > Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > > Add TestEnv class, which will handle test environment in a new python
> > > > > iotests running framework.
> > > > >
> > > > > Difference with current ./check interface:
> > > > > - -v (verbose) option dropped, as it is unused
> > > > >
> > > > > - -xdiff option is dropped, until somebody complains that it is needed
> > > > > - same for -n option
> > > > >
> > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > > > ---
> > > > > tests/qemu-iotests/testenv.py | 328
> > > > > ++++++++++++++++++++++++++++++++++
> > > > > 1 file changed, 328 insertions(+)
> > > > > create mode 100755 tests/qemu-iotests/testenv.py
> > > > >
>
> [..]
>
> > > > > + def init_binaries(self):
> > > > > + """Init binary path variables:
> > > > > + PYTHON (for bash tests)
> > > > > + QEMU_PROG, QEMU_IMG_PROG, QEMU_IO_PROG, QEMU_NBD_PROG,
> > > > > QSD_PROG
> > > > > + SOCKET_SCM_HELPER
> > > > > + """
> > > > > + self.python = '/usr/bin/python3 -B'
> > > >
> > > > This doesn't look right, we need to respect the Python binary set in
> > > > configure (which I think we get from common.env)
> > >
> > > Oh, I missed the change. Then I should just drop this self.python.
> >
> > Do we still get the value from elsewhere or do we need to manually parse
> > common.env?
>
> Hmm.. Good question. We have either parse common.env, and still create
> self.python variable.
>
> Or drop it, and include common.env directly to bash tests. For this we'll
> need to export
>
> BUILD_IOTESTS, and do
> . $BUILD_IOTESTS/common.env
>
> in common.rc..
check uses it, too, for running Python test cases.
Kevin
Re: [PATCH v6 08/11] iotests: add testenv.py, Kevin Wolf, 2021/01/15
- Re: [PATCH v6 08/11] iotests: add testenv.py, Vladimir Sementsov-Ogievskiy, 2021/01/15
- Re: [PATCH v6 08/11] iotests: add testenv.py, Kevin Wolf, 2021/01/15
- Re: [PATCH v6 08/11] iotests: add testenv.py, Vladimir Sementsov-Ogievskiy, 2021/01/15
- Re: [PATCH v6 08/11] iotests: add testenv.py,
Kevin Wolf <=
- Re: [PATCH v6 08/11] iotests: add testenv.py, Vladimir Sementsov-Ogievskiy, 2021/01/15
- Re: [PATCH v6 08/11] iotests: add testenv.py, Vladimir Sementsov-Ogievskiy, 2021/01/16
- Re: [PATCH v6 08/11] iotests: add testenv.py, Vladimir Sementsov-Ogievskiy, 2021/01/16
- Re: [PATCH v6 08/11] iotests: add testenv.py, Kevin Wolf, 2021/01/18
- Re: [PATCH v6 08/11] iotests: add testenv.py, Vladimir Sementsov-Ogievskiy, 2021/01/18
[PATCH v6 06/11] iotests: define group in each iotest, Vladimir Sementsov-Ogievskiy, 2021/01/09