[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 08/10] iotests/129: Limit mirror job's buffer size
From: |
Max Reitz |
Subject: |
[PATCH v5 08/10] iotests/129: Limit mirror job's buffer size |
Date: |
Mon, 18 Jan 2021 11:57:18 +0100 |
Issuing 'stop' on the VM drains all nodes. If the mirror job has many
large requests in flight, this may lead to significant I/O that looks a
bit like 'stop' would make the job try to complete (which is what 129
should verify not to happen).
We can limit the I/O in flight by limiting the buffer size, so mirror
will make very little progress during the 'stop' drain.
(We do not need to do anything about commit, which has a buffer size of
512 kB by default; or backup, which goes cluster by cluster. Once we
have asynchronous requests for backup, that will change, but then we can
fine-tune the backup job to only perform a single request on a very
small chunk, too.)
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
---
tests/qemu-iotests/129 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 104be6dded..80a5db521b 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -67,7 +67,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
def test_drive_mirror(self):
self.do_test_stop("drive-mirror", device="drive0",
target=self.target_img, format=iotests.imgfmt,
- sync="full")
+ sync="full", buf_size=65536)
def test_drive_backup(self):
self.do_test_stop("drive-backup", device="drive0",
--
2.29.2
- Re: [PATCH v5 02/10] iotests/297: Rewrite in Python and extend reach, (continued)
[PATCH v5 03/10] iotests: Move try_remove to iotests.py, Max Reitz, 2021/01/18
[PATCH v5 01/10] iotests.py: Assume a couple of variables as given, Max Reitz, 2021/01/18
[PATCH v5 04/10] iotests/129: Remove test images in tearDown(), Max Reitz, 2021/01/18
[PATCH v5 05/10] iotests/129: Do not check @busy, Max Reitz, 2021/01/18
[PATCH v5 06/10] iotests/129: Use throttle node, Max Reitz, 2021/01/18
[PATCH v5 07/10] iotests/129: Actually test a commit job, Max Reitz, 2021/01/18
[PATCH v5 08/10] iotests/129: Limit mirror job's buffer size,
Max Reitz <=
[PATCH v5 10/10] iotests/300: Clean up pylint and mypy complaints, Max Reitz, 2021/01/18
[PATCH v5 09/10] iotests/129: Clean up pylint and mypy complaints, Max Reitz, 2021/01/18