[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND |
|
Date: |
Wed, 27 Jan 2021 12:12:25 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/26/21 3:31 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> These cases require a bit more thought to review; in each case, the
>> code was appending to a list, but not with a FOOList **tail variable.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>> ---
>> fix qmp_guest_network_get_interfaces [Vladimir]
>
> Fails tests/test-qga. I should've double-checked earlier.
I ran 'make check', but I'll check again. In the meantime,
>
> Dropping this part unbreaks the test.
>
> I'd like to drop just this part, and merge the rest. You can then
> respin just this part as a follow-up patch. Okay?
this plan is okay with me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org