[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/11] error: rename error_with_timestamp to message_with_timestam
From: |
Stefan Hajnoczi |
Subject: |
[PULL 07/11] error: rename error_with_timestamp to message_with_timestamp |
Date: |
Mon, 1 Feb 2021 15:46:59 +0000 |
The -msg timestamp=on|off option controls whether a timestamp is printed
with error_report() messages. The "-msg" name suggests that this option
has a wider effect than just error_report(). The next patch extends it
to the 'log' trace backend, so rename the variable from
error_with_timestamp to message_with_timestamp.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210125113507.224287-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/qemu/error-report.h | 2 +-
softmmu/vl.c | 2 +-
util/qemu-error.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h
index a5ad95ff1b..9d197daca3 100644
--- a/include/qemu/error-report.h
+++ b/include/qemu/error-report.h
@@ -74,7 +74,7 @@ void error_init(const char *argv0);
const char *error_get_progname(void);
-extern bool error_with_timestamp;
+extern bool message_with_timestamp;
extern bool error_with_guestname;
extern const char *error_guest_name;
diff --git a/softmmu/vl.c b/softmmu/vl.c
index a8876b8965..bd55468669 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -737,7 +737,7 @@ static void realtime_init(void)
static void configure_msg(QemuOpts *opts)
{
- error_with_timestamp = qemu_opt_get_bool(opts, "timestamp", false);
+ message_with_timestamp = qemu_opt_get_bool(opts, "timestamp", false);
error_with_guestname = qemu_opt_get_bool(opts, "guest-name", false);
}
diff --git a/util/qemu-error.c b/util/qemu-error.c
index aa30f03564..52a9e013c4 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -25,7 +25,7 @@ typedef enum {
} report_type;
/* Prepend timestamp to messages */
-bool error_with_timestamp;
+bool message_with_timestamp;
bool error_with_guestname;
const char *error_guest_name;
@@ -208,7 +208,7 @@ static void vreport(report_type type, const char *fmt,
va_list ap)
GTimeVal tv;
gchar *timestr;
- if (error_with_timestamp && !monitor_cur()) {
+ if (message_with_timestamp && !monitor_cur()) {
g_get_current_time(&tv);
timestr = g_time_val_to_iso8601(&tv);
error_printf("%s ", timestr);
--
2.29.2
- [PULL 00/11] Tracing patches, Stefan Hajnoczi, 2021/02/01
- [PULL 01/11] trace: fix simpletrace doc mismerge, Stefan Hajnoczi, 2021/02/01
- [PULL 04/11] tracetool: fix "PRI" macro decoding, Stefan Hajnoczi, 2021/02/01
- [PULL 06/11] trace: add meson custom_target() depend_files for tracetool, Stefan Hajnoczi, 2021/02/01
- [PULL 07/11] error: rename error_with_timestamp to message_with_timestamp,
Stefan Hajnoczi <=
- [PULL 08/11] trace: make the 'log' backend timestamp configurable, Stefan Hajnoczi, 2021/02/01
- [PULL 03/11] trace: recommend "log" backend for getting started with tracing, Stefan Hajnoczi, 2021/02/01
- [PULL 02/11] tracing: convert documentation to rST, Stefan Hajnoczi, 2021/02/01
- [PULL 11/11] trace: update docs with meson build information, Stefan Hajnoczi, 2021/02/01
- [PULL 10/11] trace: document how to specify multiple --trace patterns, Stefan Hajnoczi, 2021/02/01