[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 24/24] gitlab: add python linters to CI
From: |
John Snow |
Subject: |
[PATCH v4 24/24] gitlab: add python linters to CI |
Date: |
Thu, 11 Feb 2021 13:58:56 -0500 |
Add python3.6 to the fedora container image: we need it to run the
linters against that explicit version to make sure we don't break our
minimum version promise.
Add pipenv so that we can fetch precise versions of pip packages we need
to guarantee test reproducability.
Signed-off-by: John Snow <jsnow@redhat.com>
---
.gitlab-ci.yml | 10 ++++++++++
tests/docker/dockerfiles/fedora.docker | 2 ++
2 files changed, 12 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 28a83afb914..d1ae3972956 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -633,6 +633,16 @@ check-patch:
GIT_DEPTH: 1000
allow_failure: true
+
+check-python:
+ stage: build
+ image: $CI_REGISTRY_IMAGE/qemu/fedora:latest
+ script:
+ - cd python
+ - make venv-check
+ variables:
+ GIT_DEPTH: 1000
+
check-dco:
stage: build
image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
diff --git a/tests/docker/dockerfiles/fedora.docker
b/tests/docker/dockerfiles/fedora.docker
index 0d7602abbeb..1262b8c5e03 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -84,6 +84,7 @@ ENV PACKAGES \
numactl-devel \
perl \
perl-Test-Harness \
+ pipenv \
pixman-devel \
python3 \
python3-PyYAML \
@@ -93,6 +94,7 @@ ENV PACKAGES \
python3-pip \
python3-sphinx \
python3-virtualenv \
+ python3.6 \
rdma-core-devel \
SDL2-devel \
snappy-devel \
--
2.29.2
- Re: [PATCH v4 09/24] python: add pylint import exceptions, (continued)
- [PATCH v4 10/24] python: move pylintrc into setup.cfg, John Snow, 2021/02/11
- [PATCH v4 07/24] python: add directory structure README.rst files, John Snow, 2021/02/11
- [PATCH v4 11/24] python: add pylint to pipenv, John Snow, 2021/02/11
- [PATCH v4 19/24] python: add devel package requirements to setuptools, John Snow, 2021/02/11
- [PATCH v4 24/24] gitlab: add python linters to CI,
John Snow <=
- [PATCH v4 13/24] python: Add flake8 to pipenv, John Snow, 2021/02/11
- [PATCH v4 12/24] python: move flake8 config to setup.cfg, John Snow, 2021/02/11
- [PATCH v4 16/24] python: move .isort.cfg into setup.cfg, John Snow, 2021/02/11
- [PATCH v4 15/24] python: add mypy to pipenv, John Snow, 2021/02/11
- [PATCH v4 17/24] python/qemu: add isort to pipenv, John Snow, 2021/02/11