[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 5/8] hw/sd: sd: Skip write protect groups check in sd_erase()
From: |
Bin Meng |
Subject: |
[PATCH v2 5/8] hw/sd: sd: Skip write protect groups check in sd_erase() for high capacity cards |
Date: |
Tue, 16 Feb 2021 23:02:22 +0800 |
From: Bin Meng <bin.meng@windriver.com>
High capacity cards don't support write protection hence we should
not preform the write protect groups check in sd_erase() for them.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
Changes in v2:
- new patch: sd: Skip write protect groups check in sd_erase() for high
capacity card
hw/sd/sd.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 5bd95304f1..f1f98bdec3 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -765,6 +765,7 @@ static void sd_erase(SDState *sd)
int i;
uint64_t erase_start = sd->erase_start;
uint64_t erase_end = sd->erase_end;
+ bool sdsc = true;
trace_sdcard_erase(sd->erase_start, sd->erase_end);
if (sd->erase_start == INVALID_ADDRESS
@@ -779,6 +780,7 @@ static void sd_erase(SDState *sd)
/* High capacity memory card: erase units are 512 byte blocks */
erase_start *= 512;
erase_end *= 512;
+ sdsc = false;
}
if (erase_start > sd->size || erase_end > sd->size) {
@@ -788,16 +790,20 @@ static void sd_erase(SDState *sd)
return;
}
- erase_start = sd_addr_to_wpnum(erase_start);
- erase_end = sd_addr_to_wpnum(erase_end);
sd->erase_start = INVALID_ADDRESS;
sd->erase_end = INVALID_ADDRESS;
sd->csd[14] |= 0x40;
- for (i = erase_start; i <= erase_end; i++) {
- assert(i < sd->wpgrps_size);
- if (test_bit(i, sd->wp_groups)) {
- sd->card_status |= WP_ERASE_SKIP;
+ /* Only SDSC cards support write protect groups */
+ if (sdsc) {
+ erase_start = sd_addr_to_wpnum(erase_start);
+ erase_end = sd_addr_to_wpnum(erase_end);
+
+ for (i = erase_start; i <= erase_end; i++) {
+ assert(i < sd->wpgrps_size);
+ if (test_bit(i, sd->wp_groups)) {
+ sd->card_status |= WP_ERASE_SKIP;
+ }
}
}
}
--
2.25.1
- [PATCH v2 0/8] hw/sd: sd: Erase operation and other fixes, Bin Meng, 2021/02/16
- [PATCH v2 1/8] hw/sd: sd: Fix address check in sd_erase(), Bin Meng, 2021/02/16
- [PATCH v2 2/8] hw/sd: sd: Only SDSC cards support CMD28/29/30, Bin Meng, 2021/02/16
- [PATCH v2 3/8] hw/sd: sd: Fix CMD30 response type, Bin Meng, 2021/02/16
- [PATCH v2 5/8] hw/sd: sd: Skip write protect groups check in sd_erase() for high capacity cards,
Bin Meng <=
- [PATCH v2 6/8] hw/sd: sd: Actually perform the erase operation, Bin Meng, 2021/02/16
- [PATCH v2 4/8] hw/sd: sd: Move the sd_block_{read, write} and macros ahead, Bin Meng, 2021/02/16
- [PATCH v2 7/8] hw/sd: sd: Skip write protect groups check in CMD24/25 for high capacity cards, Bin Meng, 2021/02/16
- [PATCH v2 8/8] hw/sd: sd: Bypass the RCA check for CMD13 in SPI mode, Bin Meng, 2021/02/16
- Re: [PATCH v2 0/8] hw/sd: sd: Erase operation and other fixes, Philippe Mathieu-Daudé, 2021/02/19