qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/14] ui, monitor: remove deprecated VNC ACL option and HMP


From: Thomas Huth
Subject: Re: [PATCH 01/14] ui, monitor: remove deprecated VNC ACL option and HMP commands
Date: Wed, 24 Feb 2021 14:36:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 24/02/2021 14.11, Daniel P. Berrangé wrote:
The VNC ACL concept has been replaced by the pluggable "authz" framework
which does not use monitor commands.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  docs/system/deprecated.rst       |  16 ---
  docs/system/removed-features.rst |  13 +++
  hmp-commands.hx                  |  76 -------------
  monitor/misc.c                   | 187 -------------------------------
  ui/vnc.c                         |  38 -------
  5 files changed, 13 insertions(+), 317 deletions(-)

If I run:

 grep -r vnc.*acl *

I also see some lines in tests/check-block-qdict.c ... are they related and should be removed, too?

Apart from that, patch looks fine to me:
Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]