[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/13] monitor: remove 'query-events' QMP command
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 03/13] monitor: remove 'query-events' QMP command |
Date: |
Mon, 15 Mar 2021 13:34:27 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/15/21 12:45 PM, Daniel P. Berrangé wrote:
> The code comment suggests removing QAPIEvent_(str|lookup) symbols too,
> however, these are both auto-generated as standard for any enum in
> QAPI. As such it they'll exist whether we use them or not.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> docs/system/deprecated.rst | 6 -----
> docs/system/removed-features.rst | 6 +++++
> monitor/qmp-cmds-control.c | 24 -----------------
> qapi/control.json | 45 --------------------------------
> 4 files changed, 6 insertions(+), 75 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v2 00/13] deprecations: remove many old deprecations, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 01/13] ui, monitor: remove deprecated VNC ACL option and HMP commands, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 02/13] monitor: raise error when 'pretty' option is used with HMP, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 03/13] monitor: remove 'query-events' QMP command, Daniel P . Berrangé, 2021/03/15
- Re: [PATCH v2 03/13] monitor: remove 'query-events' QMP command,
Eric Blake <=
- [PATCH v2 05/13] machine: remove 'query-cpus' QMP command, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 06/13] machine: remove 'arch' field from 'query-cpus-fast' QMP command, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 04/13] migrate: remove QMP/HMP commands for speed, downtime and cache size, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 07/13] chardev: reject use of 'wait' flag for socket client chardevs, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 08/13] hw/ide: remove 'ide-drive' device, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 09/13] hw/scsi: remove 'scsi-disk' device, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 10/13] block: remove 'encryption_key_missing' flag from QAPI, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 11/13] block: remove dirty bitmaps 'status' field, Daniel P . Berrangé, 2021/03/15
- [PATCH v2 12/13] block: remove 'dirty-bitmaps' field from 'BlockInfo' struct, Daniel P . Berrangé, 2021/03/15