Re: [RFC PATCH v2 01/11] python: qemu: add timer parameter for qmp.accept socket

[Emanuele Giuseppe Esposito]

> > --- a/python/qemu/qtest.py
> > +++ b/python/qemu/qtest.py
> > @@ -138,9 +138,9 @@ def _pre_launch(self) -> None:
> >           super()._pre_launch()
> >           self._qtest = QEMUQtestProtocol(self._qtest_path, server=True)
> > -    def _post_launch(self) -> None:
> > +    def _post_launch(self, timer) -> None:
> >           assert self._qtest is not None
> > -        super()._post_launch()
> > +        super()._post_launch(timer)
> >           self._qtest.accept()
> >       def _post_shutdown(self) -> None:
>
> Are you forgetting to change _launch() to provide some default value for 
> what timer needs to be?
>
> I think for the "event" callbacks here, I'd prefer configuring the 
> behavior as a property instead of passing it around as a parameter.

I agree, I changed it in a field of the QEMUMachine class called 
_qmp_timer that defaults to 15 seconds.

Emanuele