[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine |
Date: |
Wed, 28 Apr 2021 12:53:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/28/21 11:32 AM, Thomas Huth wrote:
> On 28/04/2021 11.24, Stefan Hajnoczi wrote:
>> On Fri, Apr 16, 2021 at 02:52:56PM +0200, Thomas Huth wrote:
>>> @@ -158,7 +166,11 @@ static void pci_piix_ide_realize(PCIDevice *dev,
>>> Error **errp)
>>> vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d);
>>> - pci_piix_init_ports(d);
>>> + rc = pci_piix_init_ports(d);
>>> + if (rc) {
>>> + error_setg_errno(errp, -rc, "Failed to realize %s",
>>> + object_get_typename(OBJECT(dev)));
>>> + }
>>
>> Is there an error message explaining the reason for the failure
>> somewhere. I can't see one in the patch and imagine users will be
>> puzzled/frustrated by a generic "Failed to realize" error message. Can
>> you make it more meaningful?
>
> Do you have a suggestion for a better message?
At this point it is hard to do better... Else we'd need to propagate
a meaningful Error* from ide_init_ioport(), and emit something like
"Failed to initialize the ISA bus"?
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, (continued)
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, John Snow, 2021/04/27
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Markus Armbruster, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Markus Armbruster, 2021/04/29
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28
- Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Markus Armbruster, 2021/04/28
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, John Snow, 2021/04/27
Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine, Stefan Hajnoczi, 2021/04/28