Re: [PATCH v3 01/33] block/nbd: fix channel object leak

[Vladimir Sementsov-Ogievskiy]

25.05.2021 00:31, Eric Blake wrote:
> On Fri, Apr 16, 2021 at 11:08:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > From: Roman Kagan <rvkagan@yandex-team.ru>
> >
> > nbd_free_connect_thread leaks the channel object if it hasn't been
> > stolen.
> >
> > Unref it and fix the leak.
> >
> > Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> > ---
> >   block/nbd.c | 1 +
> >   1 file changed, 1 insertion(+)
>
> Does nbd_yank() have a similar problem?

No, I think not. nbd_yank() just shutdown the socket to cancel in-flight 
requests. I doesn't release the state.

> At any rate, this makes sense to me.
> Reviewed-by: Eric Blake <eblake@redhat.com>


--
Best regards,
Vladimir