[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 16/44] python/machine: use subprocess.run instead of subprocess.Po
From: |
John Snow |
Subject: |
[PULL 16/44] python/machine: use subprocess.run instead of subprocess.Popen |
Date: |
Thu, 27 May 2021 22:31:52 -0400 |
use run() instead of Popen() -- to assert to pylint that we are not
forgetting to close a long-running program.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210527211715.394144-4-jsnow@redhat.com
Message-id: 20210517184808.3562549-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine.py | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 5b87e9ce024..04e005f3811 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -223,13 +223,16 @@ def send_fd_scm(self, fd: Optional[int] = None,
assert fd is not None
fd_param.append(str(fd))
- proc = subprocess.Popen(
- fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE,
- stderr=subprocess.STDOUT, close_fds=False
+ proc = subprocess.run(
+ fd_param,
+ stdin=subprocess.DEVNULL,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ check=False,
+ close_fds=False,
)
- output = proc.communicate()[0]
- if output:
- LOG.debug(output)
+ if proc.stdout:
+ LOG.debug(proc.stdout)
return proc.returncode
--
2.31.1
- [PULL 06/44] Acceptance Tests: add port redirection for ssh by default, (continued)
- [PULL 06/44] Acceptance Tests: add port redirection for ssh by default, John Snow, 2021/05/27
- [PULL 07/44] Acceptance Tests: make username/password configurable, John Snow, 2021/05/27
- [PULL 08/44] Acceptance Tests: set up SSH connection by default after boot for LinuxTest, John Snow, 2021/05/27
- [PULL 09/44] tests/acceptance/virtiofs_submounts.py: remove launch_vm(), John Snow, 2021/05/27
- [PULL 10/44] Acceptance Tests: add basic documentation on LinuxTest base class, John Snow, 2021/05/27
- [PULL 11/44] Acceptance Tests: introduce CPU hotplug test, John Snow, 2021/05/27
- [PULL 12/44] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey, John Snow, 2021/05/27
- [PULL 14/44] python/console_socket: avoid one-letter variable, John Snow, 2021/05/27
- [PULL 13/44] acceptance tests: bump Avocado version to 88.1, John Snow, 2021/05/27
- [PULL 15/44] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull), John Snow, 2021/05/27
- [PULL 16/44] python/machine: use subprocess.run instead of subprocess.Popen,
John Snow <=
- [PULL 17/44] python/console_socket: Add a pylint ignore, John Snow, 2021/05/27
- [PULL 18/44] python/machine: Disable pylint warning for open() in _pre_launch, John Snow, 2021/05/27
- [PULL 21/44] iotests/297: add --namespace-packages to mypy arguments, John Snow, 2021/05/27
- [PULL 19/44] python/machine: disable warning for Popen in _launch(), John Snow, 2021/05/27
- [PULL 20/44] python/machine: Trim line length to below 80 chars, John Snow, 2021/05/27
- [PULL 22/44] python: create qemu packages, John Snow, 2021/05/27
- [PULL 23/44] python: add qemu package installer, John Snow, 2021/05/27
- [PULL 24/44] python: add VERSION file, John Snow, 2021/05/27
- [PULL 25/44] python: add directory structure README.rst files, John Snow, 2021/05/27
- [PULL 26/44] python: add MANIFEST.in, John Snow, 2021/05/27