qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept so


From: John Snow
Subject: Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket
Date: Wed, 2 Jun 2021 19:23:14 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote:
Alsp add a new _qmp_timer field to the QEMUMachine class.

Let's change the default socket timeout to None, so that if
a subclass needs to add a timer, it can be done by modifying
this private field.

At the same time, restore the timer to be 15 seconds in iotests.py, to
give an upper bound to qemu-iotests execution.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>

Hi Emanuele: I'm sorry, but with the recent Python PR this no longer applies to origin/master -- the python files got shuffled around a bit when I added the new CI tests.

May I please ask you to rebase? You don't have to re-spin just yet, just pointing me to the rebase would help me out.

(Also: if you push to gitlab, you can take advantage of the new Python CI tests!)

Apologies,
--js




reply via email to

[Prev in Thread] Current Thread [Next in Thread]