Re: [PATCH] iotests/check: move general long options to double dash

[Vladimir Sementsov-Ogievskiy]

03.06.2021 14:38, Paolo Bonzini wrote:
> On 26/05/21 20:16, Vladimir Sementsov-Ogievskiy wrote:
> > So, the change:
> >
> >    -makecheck -> --makecheck
> >    -valgrind  -> --valgrind
> >    -nocache   -> --nocache
> >    -misalign  -> --misalign
> >
> > Motivation:
> >
> > 1. Several long options are already have double dash:
> >    --dry-run, --color, --groups, --exclude-groups, --start-from
> >
> > 2. -misalign is used to add --misalign option (two dashes) to qemu-io
> >
> > 3. qemu-io and qemu-nbd has --nocache option (two dashes)
>
> Just like for QEMU, let me reiterate that this is generally not an improvement.
>
> Double-dash options give extra information to the user that short (single-dash) 
> options can be combined, while this is not the case for iotests/check.

You can combine short options for check script, as argparse supports it.

We don't have many short options yet.. But something like

./check -ng auto

makes sense and works..


--
Best regards,
Vladimir