Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

[Thomas Huth]

On 08/06/2021 17.35, Alex Bennée wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
> > On 08/06/2021 16.27, Alex Bennée wrote:
> > > Richard Henderson <richard.henderson@linaro.org> writes:
> > >
> > > > On 6/4/21 8:53 AM, Alex Bennée wrote:
> > > > > The assumption that the qemu-system-aarch64 image can run all 32 bit
> > > > > machines is about to be broken...
> > > >
> > > > Um, what?
> > > Really what we want is to probe the -M (machines) that a binary
> > > supports rather than just barfing the test because we've built a QEMU
> > > that doesn't support all the random 32 bit machines.
> > >
> > > > r~
> > > >
> > > >
> > > >
> > > >    and besides it's not likely this is
> > > > > improving out coverage by much. Test the "virt" machine for both arm
> > > > > and aarch64 as it can be used by either architecture.
> > > I think this point still stands though, I don't think we get much
> > > from
> > > running the cdrom test with realview et all on qemu-system-aarch64.
> >
> > In a lot of CI pipelines, we are either building aarch64 or arm, but
> > not both, so I think it might be good to keep the tests in here.
>
> We do test instantiating the cdrom with -M virt, exactly how many extra
> lines of coverage do we get for the rest?

$ grep -r block_default_type.*IF_ hw/arm/
hw/arm/tosa.c:    mc->block_default_type = IF_IDE;
hw/arm/cubieboard.c:    mc->block_default_type = IF_IDE;
hw/arm/virt.c:    mc->block_default_type = IF_VIRTIO;
hw/arm/spitz.c:    mc->block_default_type = IF_IDE;
hw/arm/orangepi.c:    mc->block_default_type = IF_SD;
hw/arm/raspi.c:    mc->block_default_type = IF_SD;
hw/arm/realview.c:    mc->block_default_type = IF_SCSI;
hw/arm/realview.c:    mc->block_default_type = IF_SCSI;
hw/arm/xlnx-zcu102.c:    mc->block_default_type = IF_IDE;
hw/arm/highbank.c:    mc->block_default_type = IF_IDE;
hw/arm/highbank.c:    mc->block_default_type = IF_IDE;
hw/arm/sbsa-ref.c:    mc->block_default_type = IF_IDE;
hw/arm/versatilepb.c:    mc->block_default_type = IF_SCSI;
hw/arm/versatilepb.c:    mc->block_default_type = IF_SCSI;

... thus these tests check quite a bit of different ways to pass a cdrom 
drive to the machine. I'd rather suggest to keep them, but you're the arm 
guy here, so if you don't like these tests anymore, feel free to drop them.

 Thomas