qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] vhost: Add Error parameter to vhost_dev_init()


From: Stefano Garzarella
Subject: Re: [PATCH 1/7] vhost: Add Error parameter to vhost_dev_init()
Date: Thu, 10 Jun 2021 11:05:16 +0200

On Wed, Jun 09, 2021 at 05:46:52PM +0200, Kevin Wolf wrote:
This allows callers to return better error messages instead of making
one up while the real error ends up on stderr. Most callers can
immediately make use of this because they already have an Error
parameter themselves. The others just keep printing the error with
error_report_err().

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
include/hw/virtio/vhost.h    |  2 +-
backends/cryptodev-vhost.c   |  5 ++++-
backends/vhost-user.c        |  4 ++--
hw/block/vhost-user-blk.c    |  4 ++--
hw/net/vhost_net.c           |  6 +++++-
hw/scsi/vhost-scsi.c         |  4 +---
hw/scsi/vhost-user-scsi.c    |  4 +---
hw/virtio/vhost-user-fs.c    |  3 +--
hw/virtio/vhost-user-vsock.c |  3 +--
hw/virtio/vhost-vsock.c      |  3 +--
hw/virtio/vhost.c            | 16 ++++++++++------
11 files changed, 29 insertions(+), 25 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]