[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 3/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint() |
Date: |
Tue, 15 Jun 2021 18:47:47 +0200 |
Avoid accessing QCryptoTLSCreds internals by using
the qcrypto_tls_creds_check_endpoint() helper.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
chardev/char-socket.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index daa89fe5d1d..fe6b1fe2110 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -1403,13 +1403,15 @@ static void qmp_chardev_open_socket(Chardev *chr,
}
object_ref(OBJECT(s->tls_creds));
if (is_listen) {
- if (s->tls_creds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_SERVER) {
+ if (!qcrypto_tls_creds_check_endpoint(s->tls_creds,
+ QCRYPTO_TLS_CREDS_ENDPOINT_SERVER)) {
error_setg(errp, "%s",
"Expected TLS credentials for server endpoint");
return;
}
} else {
- if (s->tls_creds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT) {
+ if (!qcrypto_tls_creds_check_endpoint(s->tls_creds,
+ QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT)) {
error_setg(errp, "%s",
"Expected TLS credentials for client endpoint");
return;
--
2.31.1
- [PATCH v2 0/7] crypto: Make QCryptoTLSCreds* structures private, Philippe Mathieu-Daudé, 2021/06/15
- [PATCH v2 1/7] crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper, Philippe Mathieu-Daudé, 2021/06/15
- [PATCH v2 2/7] block/nbd: Use qcrypto_tls_creds_check_endpoint(), Philippe Mathieu-Daudé, 2021/06/15
- [PATCH v2 3/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint(),
Philippe Mathieu-Daudé <=
- [PATCH v2 4/7] migration/tls: Use qcrypto_tls_creds_check_endpoint(), Philippe Mathieu-Daudé, 2021/06/15
- [PATCH v2 5/7] crypto/tlssession: Introduce qcrypto_tls_creds_check_endpoint() helper, Philippe Mathieu-Daudé, 2021/06/15
- [PATCH v2 6/7] ui/vnc: Use qcrypto_tls_session_check_role(), Philippe Mathieu-Daudé, 2021/06/15
- [PATCH v2 7/7] crypto: Make QCryptoTLSCreds* structures private, Philippe Mathieu-Daudé, 2021/06/15