|
From: | Max Reitz |
Subject: | Re: [PATCH 3/6] block/file-posix: Do not force-cap *pnum |
Date: | Mon, 21 Jun 2021 11:38:35 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 18.06.21 22:16, Eric Blake wrote:
On Thu, Jun 17, 2021 at 05:52:44PM +0200, Max Reitz wrote:bdrv_co_block_status() does it for us, we do not need to do it here. The advantage of not capping *pnum is that bdrv_co_block_status() can cache larger data regions than requested by its caller.We should update the documentation in include/block/block_int.h to mention that the driver's block_status callback may treat *pnum as a soft cap, and that returning a larger value is fine.
Oh, sure. Max
But I agree with this change in the individual drivers, as long as we remember to make our global contract explicit that we can now rely on it ;) Reviewed-by: Eric Blake <eblake@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |