[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 00/10] hw/sd: Start splitting SD vs SPI protocols
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH 00/10] hw/sd: Start splitting SD vs SPI protocols |
Date: |
Thu, 24 Jun 2021 16:21:59 +0200 |
Hi Cédric,
After our discussion yesterday about how to add support for MMC
(and eMMC) I looked at how to easily add these bus protocols,
which might have commands quite different, avoiding to have big
unreadable if/else statements.
I'm not yet happy enough with the result but it is a starting
point which keeps things still simple.
What I'm wondering is if we could include the command classes
(as another dimension in the array). Also if we could use the
older spec version supported as base set of commands, and if the
user asks for more recent spec version, for each version we
overwrite the array of commands. Thoughts?
Phil.
Philippe Mathieu-Daudé (10):
hw/sd: When card is in wrong state, log which state it is
hw/sd: Extract address_in_range() helper, log invalid accesses
hw/sd: Move proto_name to SDProto structure
hw/sd: Introduce sd_cmd_handler type
hw/sd: Add sd_cmd_illegal() handler
hw/sd: Add sd_cmd_unimplemented() handler
hw/sd: Add sd_cmd_GO_IDLE_STATE() handler
hw/sd: Add sd_cmd_SEND_OP_CMD() handler
hw/sd: Add sd_cmd_ALL_SEND_CID() handler
hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler
hw/sd/sd.c | 251 ++++++++++++++++++++++++++++++-----------------------
1 file changed, 143 insertions(+), 108 deletions(-)
--
2.31.1
- [RFC PATCH 00/10] hw/sd: Start splitting SD vs SPI protocols,
Philippe Mathieu-Daudé <=
- [RFC PATCH 01/10] hw/sd: When card is in wrong state, log which state it is, Philippe Mathieu-Daudé, 2021/06/24
- [RFC PATCH 02/10] hw/sd: Extract address_in_range() helper, log invalid accesses, Philippe Mathieu-Daudé, 2021/06/24
- [RFC PATCH 03/10] hw/sd: Move proto_name to SDProto structure, Philippe Mathieu-Daudé, 2021/06/24
- [RFC PATCH 04/10] hw/sd: Introduce sd_cmd_handler type, Philippe Mathieu-Daudé, 2021/06/24