|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH 0/2] introduce QEMU_AUTO_VFREE |
Date: | Mon, 28 Jun 2021 14:39:10 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
28.06.2021 13:08, Kevin Wolf wrote:
Am 23.06.2021 um 12:34 hat Kevin Wolf geschrieben:Am 19.06.2021 um 16:21 hat Vladimir Sementsov-Ogievskiy geschrieben:Hi all! There is a good movement to use g_autofree macro, that helps to automatically call g_free on exit from code block. We lack similar possibility for qemu_memalign() functions family. Let's add, it seems rather simple with help of "cleanup" attribute. I'll update more places with a follow-up if this is accepted.Good idea. Thanks, applied to the block branch.I'm afraid I have to unqueue this: Failures: 040 141 161 191 249 Failed 5 of 5 iotests Maybe semantic merge conflicts that I didn't notice while applying or rebasing.
No, looks like I just made a wrong thing and didn't run tests (hmm, or I was "lucky" and it didn't crash previous time for some reason). I remember, I checked that qemu_vfree is called. But I didn't check the pointer. Now in gdb I see that cleanup function gets pointer to pointer. So we can't reuse qemu_vfree, but need additional function. I'll resend. Sorry for the mess :( -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |