[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 0/5] replication: Bugfix and properly attach children
From: |
Lukas Straub |
Subject: |
[PATCH v5 0/5] replication: Bugfix and properly attach children |
Date: |
Mon, 12 Jul 2021 13:53:39 +0200 |
Hello Everyone,
A while ago Kevin noticed that the replication driver doesn't properly attach
the children it wants to use. Instead, it directly copies the BdrvChilds from
it's backing file, which is wrong. Ths Patchset fixes the problem, fixes a
potential crash in replication_co_writev due to missing permissions and removes
a workaround that was put in place back then.
Tested with full COLO-migration setup in my COLO testsuite.
Regards,
Lukas Straub
Changes:
-v5:
-Assert that children are writable where it's needed
-v4:
-minor style fixes
-clarify why children areguaranteed to be writable in
"replication: Remove workaround"
-Added Reviewed-by tags
-v3:
-Split up into multiple patches
-Remove s->active_disk
-Clarify child permissions in commit message
-v2: Test for BDRV_CHILD_PRIMARY in replication_child_perm, since
bs->file might not be set yet. (Vladimir)
Lukas Straub (5):
replication: Remove s->active_disk
replication: Reduce usage of s->hidden_disk and s->secondary_disk
replication: Properly attach children
replication: Assert that children are writable
replication: Remove workaround
block/replication.c | 121 ++++++++++++++++++++++++++++----------------
1 file changed, 78 insertions(+), 43 deletions(-)
--
2.20.1
pgpzfnoxPeV4C.pgp
Description: OpenPGP digital signature
- [PATCH v5 0/5] replication: Bugfix and properly attach children,
Lukas Straub <=
- [PATCH v5 2/5] replication: Reduce usage of s->hidden_disk and s->secondary_disk, Lukas Straub, 2021/07/12
- [PATCH v5 1/5] replication: Remove s->active_disk, Lukas Straub, 2021/07/12
- [PATCH v5 3/5] replication: Properly attach children, Lukas Straub, 2021/07/12
- [PATCH v5 5/5] replication: Remove workaround, Lukas Straub, 2021/07/12
- [PATCH v5 4/5] replication: Assert that children are writable, Lukas Straub, 2021/07/12