[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] tests/acceptance: Extract image_expand() helper
From: |
Cleber Rosa |
Subject: |
Re: [PATCH 4/9] tests/acceptance: Extract image_expand() helper |
Date: |
Tue, 13 Jul 2021 13:02:25 -0400 |
User-agent: |
mu4e 1.4.15; emacs 27.2 |
Philippe Mathieu-Daudé writes:
> To be able to expand an image to a non-power-of-2 value,
> extract image_expand() from image_pow2ceil_expand().
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/acceptance/boot_linux_console.py | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index 20d57c1a8c6..61069f0064f 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -35,15 +35,19 @@
> def pow2ceil(x):
> return 1 if x == 0 else 2**(x - 1).bit_length()
>
> +"""
> +Expand file size
> +"""
> +def image_expand(path, size):
> + if size != os.path.getsize(path):
> + with open(path, 'ab+') as fd:
> + fd.truncate(size)
> +
This would be a good time to make the comment section, into a proper
docstring, that is:
def image_expand(path, size):
"""Expand file size"""
if size != os.path.getsize(path):
with open(path, 'ab+') as fd:
fd.truncate(size)
- Cleber.