qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/14] iotests.py: img_info_log(): rename imgopts argument


From: Max Reitz
Subject: Re: [PATCH 01/14] iotests.py: img_info_log(): rename imgopts argument
Date: Fri, 16 Jul 2021 12:07:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We are going to support IMGOPTS environment variable like in bash
tests. Corresponding global variable in iotests.py should be called
imgopts. So to not interfere with function argument, rename it in
advance.

Signed-off-by: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>
---
  tests/qemu-iotests/210        | 8 ++++----
  tests/qemu-iotests/iotests.py | 5 +++--
  2 files changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Reminds me how I sent a huge series for having Python tests support $IMGOPTS two years ago (https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00071.html). I guess the reason it was so big and this series is comparatively small is because I mostly concerned myself with `-o data_file` (and so all the operations that currently assume that every image is a single file need to be amended).

Max




reply via email to

[Prev in Thread] Current Thread [Next in Thread]