[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] block: Clarify that @bytes is no limit on *pnum
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 3/6] block: Clarify that @bytes is no limit on *pnum |
Date: |
Tue, 17 Aug 2021 10:03:52 -0500 |
User-agent: |
NeoMutt/20210205-719-68949a |
On Thu, Aug 12, 2021 at 10:41:45AM +0200, Hanna Reitz wrote:
> .bdrv_co_block_status() implementations are free to return a *pnum that
> exceeds @bytes, because bdrv_co_block_status() in block/io.c will clamp
> *pnum as necessary.
>
> On the other hand, if drivers' implementations return values for *pnum
> that are as large as possible, our recently introduced block-status
> cache will become more effective.
>
> So, make a note in block_int.h that @bytes is no upper limit for *pnum.
>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block_int.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v3 0/6] block-status cache for data regions, Hanna Reitz, 2021/08/12
- [PATCH v3 1/6] block: Drop BDS comment regarding bdrv_append(), Hanna Reitz, 2021/08/12
- [PATCH v3 3/6] block: Clarify that @bytes is no limit on *pnum, Hanna Reitz, 2021/08/12
- Re: [PATCH v3 3/6] block: Clarify that @bytes is no limit on *pnum,
Eric Blake <=
- [PATCH v3 4/6] block/file-posix: Do not force-cap *pnum, Hanna Reitz, 2021/08/12
- [PATCH v3 2/6] block: block-status cache for data regions, Hanna Reitz, 2021/08/12
- [PATCH v3 5/6] block/gluster: Do not force-cap *pnum, Hanna Reitz, 2021/08/12
- [PATCH v3 6/6] block/iscsi: Do not force-cap *pnum, Hanna Reitz, 2021/08/12