[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/12] mirror: Keep s->synced on error
From: |
Hanna Reitz |
Subject: |
[PATCH v4 02/12] mirror: Keep s->synced on error |
Date: |
Tue, 7 Sep 2021 14:42:35 +0200 |
An error does not take us out of the READY phase, which is what
s->synced signifies. It does of course mean that source and target are
no longer in sync, but that is what s->actively_sync is for -- s->synced
never meant that source and target are in sync, only that they were at
some point (and at that point we transitioned into the READY phase).
The tangible problem is that we transition to READY once we are in sync
and s->synced is false. By resetting s->synced here, we will transition
from READY to READY once the error is resolved (if the job keeps
running), and that transition is not allowed.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
block/mirror.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 98fc66eabf..d73b704473 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -121,7 +121,6 @@ typedef enum MirrorMethod {
static BlockErrorAction mirror_error_action(MirrorBlockJob *s, bool read,
int error)
{
- s->synced = false;
s->actively_synced = false;
if (read) {
return block_job_error_action(&s->common, s->on_source_error,
--
2.31.1
- [PATCH v4 00/12] mirror: Handle errors after READY cancel, Hanna Reitz, 2021/09/07
- [PATCH v4 01/12] job: Context changes in job_completed_txn_abort(), Hanna Reitz, 2021/09/07
- [PATCH v4 03/12] mirror: Drop s->synced, Hanna Reitz, 2021/09/07
- [PATCH v4 02/12] mirror: Keep s->synced on error,
Hanna Reitz <=
- [PATCH v4 06/12] jobs: Give Job.force_cancel more meaning, Hanna Reitz, 2021/09/07
- [PATCH v4 04/12] job: Force-cancel jobs in a failed transaction, Hanna Reitz, 2021/09/07
- [PATCH v4 05/12] job: @force parameter for job_cancel_sync(), Hanna Reitz, 2021/09/07
- [PATCH v4 10/12] mirror: Stop active mirroring after force-cancel, Hanna Reitz, 2021/09/07
- [PATCH v4 07/12] job: Add job_cancel_requested(), Hanna Reitz, 2021/09/07
- [PATCH v4 08/12] mirror: Use job_is_cancelled(), Hanna Reitz, 2021/09/07