[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/12] mirror: Use job_is_cancelled()
From: |
Hanna Reitz |
Subject: |
[PATCH v4 08/12] mirror: Use job_is_cancelled() |
Date: |
Tue, 7 Sep 2021 14:42:41 +0200 |
mirror_drained_poll() returns true whenever the job is cancelled,
because "we [can] be sure that it won't issue more requests". However,
this is only true for force-cancelled jobs, so use job_is_cancelled().
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 72e02fa34e..024fa2dcea 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1177,7 +1177,7 @@ static bool mirror_drained_poll(BlockJob *job)
* from one of our own drain sections, to avoid a deadlock waiting for
* ourselves.
*/
- if (!s->common.job.paused && !s->common.job.cancelled && !s->in_drain) {
+ if (!s->common.job.paused && !job_is_cancelled(&job->job) && !s->in_drain)
{
return true;
}
--
2.31.1
- [PATCH v4 02/12] mirror: Keep s->synced on error, (continued)
- [PATCH v4 10/12] mirror: Stop active mirroring after force-cancel, Hanna Reitz, 2021/09/07
- [PATCH v4 07/12] job: Add job_cancel_requested(), Hanna Reitz, 2021/09/07
- [PATCH v4 08/12] mirror: Use job_is_cancelled(),
Hanna Reitz <=
- [PATCH v4 09/12] mirror: Check job_is_cancelled() earlier, Hanna Reitz, 2021/09/07
- [PATCH v4 12/12] iotests: Add mirror-ready-cancel-error test, Hanna Reitz, 2021/09/07
- [PATCH v4 11/12] mirror: Do not clear .cancelled, Hanna Reitz, 2021/09/07
- Re: [PATCH v4 00/12] mirror: Handle errors after READY cancel, Vladimir Sementsov-Ogievskiy, 2021/09/15