[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/4] migration: block-dirty-bitmap: add missing qemu_mute
From: |
Stefan Hajnoczi |
Subject: |
Re: [RFC PATCH 2/4] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread |
Date: |
Mon, 13 Sep 2021 14:19:54 +0100 |
On Wed, Sep 08, 2021 at 09:10:19AM -0400, Emanuele Giuseppe Esposito wrote:
> init_dirty_bitmap_migration assumes the iothread lock (BQL)
> to be held, but instead it isn't.
>
> Instead of adding the lock to qemu_savevm_state_setup(),
> follow the same pattern as the other ->save_setup callbacks
> and lock+unlock inside dirty_bitmap_save_setup().
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> migration/block-dirty-bitmap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [RFC PATCH 0/4] block layer: split block APIs in graph and I/O, Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 2/4] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread, Emanuele Giuseppe Esposito, 2021/09/08
- Re: [RFC PATCH 2/4] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread,
Stefan Hajnoczi <=
- [RFC PATCH 1/4] main-loop.h: introduce qemu_in_main_thread(), Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 4/4] block/block-backend.c: assertions for block-backend, Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API, Emanuele Giuseppe Esposito, 2021/09/08
- Re: [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API, Stefan Hajnoczi, 2021/09/13
- Re: [RFC PATCH 0/4] block layer: split block APIs in graph and I/O, Stefan Hajnoczi, 2021/09/13