[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t
From: |
Eric Blake |
Subject: |
Re: [PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t bytes |
Date: |
Wed, 6 Oct 2021 10:25:17 -0500 |
User-agent: |
NeoMutt/20210205-815-1dd940 |
On Wed, Oct 06, 2021 at 03:17:09PM +0200, Vladimir Sementsov-Ogievskiy wrote:
> We convert blk_do_pwritev_part() and some wrappers:
> blk_co_pwritev_part(), blk_co_pwritev(), blk_co_pwrite_zeroes().
>
> All functions are converted so that parameter type becomes wider, so
> all callers should be OK with it.
>
> Look at blk_do_pwritev_part() body:
> bytes is passed to:
>
> - trace_blk_co_pwritev (we update it here)
> - blk_check_byte_request, throttle_group_co_io_limits_intercept,
> bdrv_co_pwritev_part - all already has int64_t argument.
>
> Note that requests exceeding INT_MAX are still restricted by
> blk_check_byte_request().
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/sysemu/block-backend.h | 6 +++---
> block/block-backend.c | 8 ++++----
> block/trace-events | 2 +-
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 10/12] block-backend: convert blk_aio_ functions to int64_t bytes paramter, (continued)
[PATCH 11/12] block-backend: blk_pread, blk_pwrite: rename count parameter to bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 01/12] block-backend: blk_check_byte_request(): int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
- Re: [PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t bytes,
Eric Blake <=
[PATCH 02/12] block-backend: make blk_co_preadv() 64bit, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 04/12] block-backend: convert blk_co_pdiscard to int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 12/12] block-backend: drop INT_MAX restriction from blk_check_byte_request(), Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 05/12] block-backend: rename _do_ helper functions to _co_do_, Vladimir Sementsov-Ogievskiy, 2021/10/06
[PATCH 06/12] block-coroutine-wrapper.py: support BlockBackend first argument, Vladimir Sementsov-Ogievskiy, 2021/10/06