[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 06/25] include/block/block_int: split header into I/O
From: |
Stefan Hajnoczi |
Subject: |
Re: [RFC PATCH v2 06/25] include/block/block_int: split header into I/O and global state API |
Date: |
Thu, 7 Oct 2021 11:52:59 +0100 |
On Tue, Oct 05, 2021 at 10:31:56AM -0400, Emanuele Giuseppe Esposito wrote:
> +int coroutine_fn bdrv_co_copy_range_from(BdrvChild *src, int64_t src_offset,
> + BdrvChild *dst, int64_t dst_offset,
> + int64_t bytes,
> + BdrvRequestFlags read_flags,
> + BdrvRequestFlags write_flags);
> +int coroutine_fn bdrv_co_copy_range_to(BdrvChild *src, int64_t src_offset,
> + BdrvChild *dst, int64_t dst_offset,
> + int64_t bytes,
> + BdrvRequestFlags read_flags,
> + BdrvRequestFlags write_flags);
These look like I/O APIs to me. Are they in the GS API because only
qemu-img.c call copy_range? I thought SCSI emulation might call it too,
but grep says otherwise.
Otherwise:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature