[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 10/15] qemu-option: Allow deleting opts during qemu_opts_forea
From: |
Kevin Wolf |
Subject: |
[PATCH v2 10/15] qemu-option: Allow deleting opts during qemu_opts_foreach() |
Date: |
Fri, 8 Oct 2021 15:34:37 +0200 |
Use QTAILQ_FOREACH_SAFE() so that the current QemuOpts can be deleted
while iterating through the whole list.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
util/qemu-option.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 61cb4a97bd..eedd08929b 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -1126,11 +1126,11 @@ int qemu_opts_foreach(QemuOptsList *list,
qemu_opts_loopfunc func,
void *opaque, Error **errp)
{
Location loc;
- QemuOpts *opts;
+ QemuOpts *opts, *next;
int rc = 0;
loc_push_none(&loc);
- QTAILQ_FOREACH(opts, &list->head, next) {
+ QTAILQ_FOREACH_SAFE(opts, &list->head, next, next) {
loc_restore(&opts->loc);
rc = func(opaque, opts, errp);
if (rc) {
--
2.31.1
- [PATCH v2 02/15] net/vhost-user: Fix device compatibility check, (continued)
[PATCH v2 05/15] iotests/245: Fix type for iothread property, Kevin Wolf, 2021/10/08
[PATCH v2 10/15] qemu-option: Allow deleting opts during qemu_opts_foreach(),
Kevin Wolf <=
[PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts, Kevin Wolf, 2021/10/08
[PATCH v2 13/15] virtio-net: Avoid QemuOpts in failover_find_primary_device(), Kevin Wolf, 2021/10/08
[PATCH v2 11/15] qdev: Add Error parameter to hide_device() callbacks, Kevin Wolf, 2021/10/08
[PATCH v2 12/15] virtio-net: Store failover primary opts pointer locally, Kevin Wolf, 2021/10/08
[PATCH v2 14/15] qdev: Base object creation on QDict rather than QemuOpts, Kevin Wolf, 2021/10/08
[PATCH v2 15/15] vl: Enable JSON syntax for -device, Kevin Wolf, 2021/10/08