[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 10/15] iotests/297: split test into sub-cases
From: |
John Snow |
Subject: |
[PATCH v2 10/15] iotests/297: split test into sub-cases |
Date: |
Tue, 19 Oct 2021 10:49:13 -0400 |
Take iotest 297's main() test function and split it into two sub-cases
that can be skipped individually. We can also drop custom environment
setup from the pylint test as it isn't needed.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/297 | 63 ++++++++++++++++++++++++++----------------
1 file changed, 39 insertions(+), 24 deletions(-)
diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
index b2ad8d1cbe0..b7d9d6077b3 100755
--- a/tests/qemu-iotests/297
+++ b/tests/qemu-iotests/297
@@ -82,36 +82,51 @@ def run_linter(
)
+def check_linter(linter: str) -> bool:
+ try:
+ run_linter(linter, ['--version'], suppress_output=True)
+ except subprocess.CalledProcessError:
+ iotests.case_notrun(f"'{linter}' not found")
+ return False
+ return True
+
+
+def test_pylint(files: List[str]) -> None:
+ print('=== pylint ===')
+ sys.stdout.flush()
+
+ if not check_linter('pylint'):
+ return
+
+ run_linter('pylint', files)
+
+
+def test_mypy(files: List[str]) -> None:
+ print('=== mypy ===')
+ sys.stdout.flush()
+
+ if not check_linter('mypy'):
+ return
+
+ env = os.environ.copy()
+ env['MYPYPATH'] = env['PYTHONPATH']
+
+ run_linter('mypy', files, env=env, suppress_output=True)
+
+
def main() -> None:
- for linter in ('pylint', 'mypy'):
- try:
- run_linter(linter, ['--version'], suppress_output=True)
- except subprocess.CalledProcessError:
- iotests.notrun(f"'{linter}' not found")
-
files = get_test_files()
iotests.logger.debug('Files to be checked:')
iotests.logger.debug(', '.join(sorted(files)))
- env = os.environ.copy()
- env['MYPYPATH'] = env['PYTHONPATH']
-
- print('=== pylint ===')
- sys.stdout.flush()
- try:
- run_linter('pylint', files, env=env)
- except subprocess.CalledProcessError:
- # pylint failure will be caught by diffing the IO.
- pass
-
- print('=== mypy ===')
- sys.stdout.flush()
- try:
- run_linter('mypy', files, env=env, suppress_output=True)
- except subprocess.CalledProcessError as exc:
- if exc.output:
- print(exc.output)
+ for test in (test_pylint, test_mypy):
+ try:
+ test(files)
+ except subprocess.CalledProcessError as exc:
+ # Linter failure will be caught by diffing the IO.
+ if exc.output:
+ print(exc.output)
iotests.script_main(main)
--
2.31.1
- [PATCH v2 01/15] iotests/297: Move pylint config into pylintrc, (continued)
- [PATCH v2 01/15] iotests/297: Move pylint config into pylintrc, John Snow, 2021/10/19
- [PATCH v2 03/15] iotests/297: Add get_files() function, John Snow, 2021/10/19
- [PATCH v2 04/15] iotests/297: Create main() function, John Snow, 2021/10/19
- [PATCH v2 05/15] iotests/297: Don't rely on distro-specific linter binaries, John Snow, 2021/10/19
- [PATCH v2 02/15] iotests/297: Split mypy configuration out into mypy.ini, John Snow, 2021/10/19
- [PATCH v2 06/15] iotests/297: Split run_linters apart into run_pylint and run_mypy, John Snow, 2021/10/19
- [PATCH v2 07/15] iotests/297: refactor run_[mypy|pylint] as generic execution shim, John Snow, 2021/10/19
- [PATCH v2 09/15] iotests/297: update tool availability checks, John Snow, 2021/10/19
- [PATCH v2 10/15] iotests/297: split test into sub-cases,
John Snow <=
- [PATCH v2 08/15] iotests/297: Change run_linter() to raise an exception on failure, John Snow, 2021/10/19
- [PATCH v2 12/15] iotests/linters: Add entry point for linting via Python CI, John Snow, 2021/10/19